[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <63aacc6d-8e3c-476d-938f-cce25d74a6b5@stanley.mountain>
Date: Fri, 13 Sep 2024 16:21:05 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Qianqiang Liu <qianqiang.liu@....com>
Cc: ematsumiya@...e.de, sfrench@...ba.org, linux-cifs@...r.kernel.org,
samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] smb: client: compress: fix an "illegal accesses" issue
On Fri, Sep 13, 2024 at 11:27:51AM +0800, Qianqiang Liu wrote:
> Using uninitialized value "bkt" when calling "kfree"
>
> Fixes: 13b68d44990d9 ("smb: client: compress: LZ77 code improvements cleanup")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
Thanks.
Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
I was reviewing this static checker warning. I also have an unpublished warning
which complains about collect_sample().
fs/smb/client/compress.c:207 collect_sample() warn: should we be adding 'len' of the min_t value?
It's a bit weird to sample data from each page. Could we add some comments at
the top of the function explaining what the function does.
/*
* This reads a 2k sample from the start of each page to see the data is already
* compressed or whether we can compress it further.
*/
regards,
dan carpenter
Powered by blists - more mailing lists