linux-kernel - RE: [PATCH 1/2] arm64: dt: imx93-tqma9352-mba93xxca: enable Open Drain for MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459AEC9C8D156EF23FAF0A688652@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Fri, 13 Sep 2024 02:54:41 +0000
From: Peng Fan <peng.fan@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
	<s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>
CC: Markus Niebel <Markus.Niebel@...tq-group.com>, "linux@...tq-group.com"
	<linux@...tq-group.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] arm64: dt: imx93-tqma9352-mba93xxca: enable Open
 Drain for MDIO

> Subject: [PATCH 1/2] arm64: dt: imx93-tqma9352-mba93xxca: enable
> Open Drain for MDIO
> 
> From: Markus Niebel <Markus.Niebel@...tq-group.com>
> 
> Follow suggestion from hardware team.

This is a bit vague, my guess:

The board has a pull-up resistor for MDIO pin per PHY design guide.
When MDIO is idle, it needs to be high and open drain is better
to be used here for power saving.

Regards,
Peng.
> 
> Signed-off-by: Markus Niebel <Markus.Niebel@...tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  .../arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts | 8
> ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> mba93xxca.dts b/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> mba93xxca.dts
> index 599df32976e24..8e939d716aac8 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352-mba93xxca.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352-
> mba93xxca.dts
> @@ -627,8 +627,8 @@ pinctrl_eqos: eqosgrp {
>  		fsl,pins = <
>  			/* PD | FSEL_2 | DSE X4 */
>  			MX93_PAD_ENET1_MDC__ENET_QOS_MDC
> 			0x51e
> -			/* SION | HYS | FSEL_2 | DSE X4 */
> -
> 	MX93_PAD_ENET1_MDIO__ENET_QOS_MDIO
> 	0x4000111e
> +			/* SION | HYS | ODE | FSEL_2 | DSE X4 */
> +
> 	MX93_PAD_ENET1_MDIO__ENET_QOS_MDIO
> 	0x4000191e
>  			/* HYS | FSEL_0 | DSE no drive */
> 
> 	MX93_PAD_ENET1_RD0__ENET_QOS_RGMII_RD0
> 	0x1000
> 
> 	MX93_PAD_ENET1_RD1__ENET_QOS_RGMII_RD1
> 	0x1000
> @@ -659,8 +659,8 @@ pinctrl_fec: fecgrp {
>  		fsl,pins = <
>  			/* PD | FSEL_2 | DSE X4 */
>  			MX93_PAD_ENET2_MDC__ENET1_MDC
> 		0x51e
> -			/* SION | HYS | FSEL_2 | DSE X4 */
> -			MX93_PAD_ENET2_MDIO__ENET1_MDIO
> 		0x4000111e
> +			/* SION | HYS | ODE | FSEL_2 | DSE X4 */
> +			MX93_PAD_ENET2_MDIO__ENET1_MDIO
> 		0x4000191e
>  			/* HYS | FSEL_0 | DSE no drive */
>  			MX93_PAD_ENET2_RD0__ENET1_RGMII_RD0
> 		0x1000
>  			MX93_PAD_ENET2_RD1__ENET1_RGMII_RD1
> 		0x1000
> --
> 2.34.1
>