linux-kernel - Re: [PATCH v2] input: tegra: Use of_property_read_variable_u32_array() and of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZuUqWNVXKO94fQuK@google.com>
Date: Fri, 13 Sep 2024 23:16:56 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Laxman Dewangan <ldewangan@...dia.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Thierry Reding <treding@...dia.com>, linux-input@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] input: tegra: Use
 of_property_read_variable_u32_array() and of_property_present()

On Fri, Sep 13, 2024 at 03:08:26PM -0500, Rob Herring (Arm) wrote:
> There's no need to get the length of an DT array property before
> parsing the array. of_property_read_variable_u32_array() takes a
> minimum and maximum length and returns the actual length (or error
> code).
> 
> This is part of a larger effort to remove callers of of_get_property()
> and similar functions. of_get_property() leaks the DT property data
> pointer which is a problem for dynamically allocated nodes which may
> be freed.
> 
> Acked-by: Thierry Reding <treding@...dia.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Applied, thank you.

-- 
Dmitry