linux-kernel - Re: [PATCH] crypto: lib/mpi - Fix an "Uninitialized scalar variable" issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZuTeivSjXN_uP-dZ@iZbp1asjb3cy8ks0srf007Z>
Date: Sat, 14 Sep 2024 08:53:30 +0800
From: Qianqiang Liu <qianqiang.liu@....com>
To: davem@...emloft.net
Cc: herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: lib/mpi - Fix an "Uninitialized scalar variable"
 issue

On Fri, Sep 13, 2024 at 10:07:42PM +0800, Qianqiang Liu wrote:
> The "err" variable may be returned without an initialized value.
> 
> Fixes: 8e3a67f2de87 ("crypto: lib/mpi - Add error checks to extension")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
> ---
>  lib/crypto/mpi/mpi-mul.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/crypto/mpi/mpi-mul.c b/lib/crypto/mpi/mpi-mul.c
> index 892a246216b9..7e6ff1ce3e9b 100644
> --- a/lib/crypto/mpi/mpi-mul.c
> +++ b/lib/crypto/mpi/mpi-mul.c
> @@ -21,7 +21,7 @@ int mpi_mul(MPI w, MPI u, MPI v)
>  	int usign, vsign, sign_product;
>  	int assign_wp = 0;
>  	mpi_ptr_t tmp_limb = NULL;
> -	int err;
> +	int err = 0;
>  
>  	if (u->nlimbs < v->nlimbs) {
>  		/* Swap U and V. */
> -- 
> 2.34.1

Could you please review this patch?

-- 
Best,
Qianqiang Liu