linux-kernel - Re: [PATCH] net: sparx5: Fix invalid timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914083828.GC8319@kernel.org>
Date: Sat, 14 Sep 2024 09:38:28 +0100
From: Simon Horman <horms@...nel.org>
To: Aakash Menon <aakash.r.menon@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, lars.povlsen@...rochip.com,
	Steen.Hegelund@...rochip.com, daniel.machon@...rochip.com,
	UNGLinuxDriver@...rochip.com, aakash.menon@...tempis.com,
	horatiu.vultur@...rochip.com, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sparx5: Fix invalid timestamps

On Fri, Sep 13, 2024 at 12:33:57PM -0700, Aakash Menon wrote:
> Bit 270-271 are occasionally unexpectedly set by the hardware.
> 
> This issue was observed with 10G SFPs causing huge time errors (> 30ms) in PTP.
> 
> Only 30 bits are needed for the nanosecond part of the timestamp, clear 2 most significant bits before extracting timestamp from the internal frame header.

Hi Aakash,

Thanks for your patch.

I'll leave the review of the code change itself to others,
but here is some feedback on process.

Please line-wrap patch descriptions at 75 columns wide.

Link: https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

Assuming this is a bug fix, a Fixes tag should be present.
It should go just before the signed-off-by line (or other tags),
with no blank lines in between.

I'm wondering if this Fixes tag is appropriate:

Fixes: 70dfe25cd866 ("net: sparx5: Update extraction/injection for timestamping")
> Signed-off-by: Aakash Menon <aakash.menon@...tempis.com>

Also, for reference, fixes for Networking should, in general,
be targeted at the net tree.

	Subject: [PATCH net] ...

And lastly, if you do post a new patch, be sure to wait 24h since
the original patch posting before doing so.

Link: https://docs.kernel.org/process/maintainer-netdev.html

...