linux-kernel - Re: [PATCH] kbuild: remove unnecessary export of RUST_LIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914-wonderful-orthodox-wrasse-3ab134@lindesnes>
Date: Sat, 14 Sep 2024 09:14:58 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Wedson Almeida Filho <wedsonaf@...il.com>,
	rust-for-linux@...r.kernel.org, Finn Behrens <me@...enk.de>,
	linux-kernel@...r.kernel.org, Alice Ryhl <aliceryhl@...gle.com>,
	Andreas Hindborg <a.hindborg@...sung.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] kbuild: remove unnecessary export of RUST_LIB_SRC

On Sat, Sep 14, 2024 at 03:06:20AM +0900, Masahiro Yamada wrote:
> If RUST_LIB_SRC is defined in the top-level Makefile (via an environment
> variable or command line), it is already exported.
> 
> The only situation where it is defined but not exported is when the
> top-level Makefile is wrapped by another Makefile (e.g., GNUmakefile).
> I cannot think of any other use cases.
> 
> I know some people use this tip to define custom variables. However,
> even in that case, you can export it directly in the wrapper Makefile.
> 
> Example GNUmakefile:
> 
>     export RUST_LIB_SRC = /path/to/your/sysroot/lib/rustlib/src/rust/library
>     include Makefile
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> This code was added by this commit:
> 
>   https://github.com/Rust-for-Linux/linux/commit/3f46885dc03ed2d750085b2237078a1628323964
> 
> Please me know if I am missing something.

Looks good to me.

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>