linux-kernel - Re: [syzbot] [xfs?] possible deadlock in xfs_can_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914090051.636332-1-lizhi.xu@windriver.com>
Date: Sat, 14 Sep 2024 17:00:51 +0800
From: Lizhi Xu <lizhi.xu@...driver.com>
To: <syzbot+53d541c7b07d55a392ca@...kaller.appspotmail.com>
CC: <chandan.babu@...cle.com>, <djwong@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-xfs@...r.kernel.org>,
        <syzkaller-bugs@...glegroups.com>
Subject: Re: [syzbot] [xfs?] possible deadlock in xfs_can_free_eofblocks (2)

we use GFP_NOFS for sbp

#syz test

diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
index 7db386304875..0dc4600010b8 100644
--- a/fs/xfs/xfs_attr_list.c
+++ b/fs/xfs/xfs_attr_list.c
@@ -114,7 +114,7 @@ xfs_attr_shortform_list(
 	 * It didn't all fit, so we have to sort everything on hashval.
 	 */
 	sbsize = sf->count * sizeof(*sbuf);
-	sbp = sbuf = kmalloc(sbsize, GFP_KERNEL | __GFP_NOFAIL);
+	sbp = sbuf = kmalloc(sbsize, GFP_NOFS | __GFP_NOFAIL);
 
 	/*
 	 * Scan the attribute list for the rest of the entries, storing