linux-kernel - Re: [RFC PATCH 00/39] 1G page support for guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGtprH-GczOb64XrLpdW4ObRG7Gsv8tHWNhiW7=2dE=OAF7-Rw@mail.gmail.com>
Date: Sat, 14 Sep 2024 06:34:36 -0700
From: Vishal Annapurve <vannapurve@...gle.com>
To: "Du, Fan" <fan.du@...el.com>
Cc: Ackerley Tng <ackerleytng@...gle.com>, "tabba@...gle.com" <tabba@...gle.com>, 
	"quic_eberman@...cinc.com" <quic_eberman@...cinc.com>, "roypat@...zon.co.uk" <roypat@...zon.co.uk>, 
	"jgg@...dia.com" <jgg@...dia.com>, "peterx@...hat.com" <peterx@...hat.com>, 
	"david@...hat.com" <david@...hat.com>, "rientjes@...gle.com" <rientjes@...gle.com>, 
	"fvdl@...gle.com" <fvdl@...gle.com>, "jthoughton@...gle.com" <jthoughton@...gle.com>, 
	"seanjc@...gle.com" <seanjc@...gle.com>, "pbonzini@...hat.com" <pbonzini@...hat.com>, 
	"Li, Zhiquan1" <zhiquan1.li@...el.com>, "Miao, Jun" <jun.miao@...el.com>, 
	"Yamahata, Isaku" <isaku.yamahata@...el.com>, "muchun.song@...ux.dev" <muchun.song@...ux.dev>, 
	"mike.kravetz@...cle.com" <mike.kravetz@...cle.com>, "Aktas, Erdem" <erdemaktas@...gle.com>, 
	"qperret@...gle.com" <qperret@...gle.com>, "jhubbard@...dia.com" <jhubbard@...dia.com>, 
	"willy@...radead.org" <willy@...radead.org>, "shuah@...nel.org" <shuah@...nel.org>, 
	"brauner@...nel.org" <brauner@...nel.org>, "bfoster@...hat.com" <bfoster@...hat.com>, 
	"kent.overstreet@...ux.dev" <kent.overstreet@...ux.dev>, "pvorel@...e.cz" <pvorel@...e.cz>, 
	"rppt@...nel.org" <rppt@...nel.org>, "richard.weiyang@...il.com" <richard.weiyang@...il.com>, 
	"anup@...infault.org" <anup@...infault.org>, "Xu, Haibo1" <haibo1.xu@...el.com>, 
	"ajones@...tanamicro.com" <ajones@...tanamicro.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>, 
	"Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>, "pgonda@...gle.com" <pgonda@...gle.com>, 
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, 
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>, 
	"linux-fsdevel@...ck.org" <linux-fsdevel@...ck.org>
Subject: Re: [RFC PATCH 00/39] 1G page support for guest_memfd

On Fri, Sep 13, 2024 at 6:08 PM Du, Fan <fan.du@...el.com> wrote:
>
> ...
> >
> > Hello,
> >
> > This patchset is our exploration of how to support 1G pages in guest_memfd,
> > and
> > how the pages will be used in Confidential VMs.
> >
> > The patchset covers:
> >
> > + How to get 1G pages
> > + Allowing mmap() of guest_memfd to userspace so that both private and
> > shared
>
> Hi Ackerley
>
> Thanks for posting new version :)
>
> W.r.t above description and below patch snippet from Patch 26-29,
> Does this new design aim to backup shared and private GPA with a single
> Hugetlb spool which equal VM instance total memory?

Yes.
>
> By my understanding, before this new changes, shared memfd and gmem fd
> has dedicate hugetlb pool, that's two copy/reservation of hugetlb spool.

Selftests attached to this series use single gmem fd to back guest memory.

>
> Does Qemu require new changes as well? I'd like to have a test of this series
> if you can share Qemu branch?
>

We are going to discuss this RFC series and related issues at LPC.
Once the next steps are finalized, the plan will be to send out an
improved version. You can use/modify the selftests that are part of
this series to test this feature with software protected VMs for now.

Qemu will require changes for this feature on top of already floated
gmem integration series [1] that adds software protected VM support to
Qemu. If you are interested in testing this feature with TDX VMs then
it needs multiple series to set up the right test environment
(including [2]). We haven't considered posting Qemu patches and it
will be a while before we can get to it.

[1] https://patchew.org/QEMU/20230914035117.3285885-1-xiaoyao.li@intel.com/
[2] https://patchwork.kernel.org/project/kvm/cover/20231115071519.2864957-1-xiaoyao.li@intel.com/