linux-kernel - Re: [PATCH V2 1/2] interconnect: Add character pointer initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024091454-shrouded-dynamite-7253@gregkh>
Date: Sat, 14 Sep 2024 15:56:58 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Yibin Ding <Yibin.Ding@...soc.com>
Cc: djakov@...nel.org, rafael@...nel.org, yibin.ding01@...il.com,
	niuzhiguo84@...il.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Hao_hao.Wang@...soc.com,
	Ke.Wang@...soc.com
Subject: Re: [PATCH V2 1/2] interconnect: Add character pointer initialization

On Sat, Sep 14, 2024 at 06:24:35PM +0800, Yibin Ding wrote:
> From: Yibin Ding <Yibin.ding@...soc.com>
> 
> When accessing a node whose data type is a character pointer and has not
> been initialized, a crash will occur due to accessing a null pointer. So
> it is necessary to add the operation of initializing the character pointer.
> Since the debugfs_write_file_str() function performs a kfree() operation
> on the node data, memory is allocated to the node pointer during
> initialization will be released when data is written to the node.

But if no data is ever written this ends up being a memory leak.  Please
do not fix one bug just to introduce another one.

> Signed-off-by: Yibin Ding <Yibin.ding@...soc.com>

also, your patches are not in a series together for some reason, and
there's no information below the --- line showing what changed from the
previous version where I pointed out this very problem :(

greg k-h