linux-kernel - Re: [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914153617.3f816e5a@jic23-huawei>
Date: Sat, 14 Sep 2024 15:36:17 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
 ang.iglesiasg@...il.com, linus.walleij@...aro.org,
 biju.das.jz@...renesas.com, javier.carrasco.cruz@...il.com,
 semen.protsenko@...aro.org, 579lpy@...il.com, ak@...klinger.de,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt
 support

On Sat, 14 Sep 2024 02:28:56 +0200
Vasileios Amoiridis <vassilisamir@...il.com> wrote:

> Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@gmail.com
> 
This looks fine, but given outstanding comments on that patch I can't
take it quite yet.

Jonathan

> Changes in v7:
> 
> [PATCH 1/4]:
> 	- Use 5ms instead of 5000us in comment
> 	- Use USEC_PER_MSEC
> 	- Move parenthesis to make checkpatch.pl --strict happy
> 
> [PATCH 2/4]:
> 	- Remove interrupt description since enforcement was added.
> 
> Added also review tags for patches 1,3 and ack tag for patch 2.
> 
> ---
> v6: https://lore.kernel.org/linux-iio/20240912233234.45519-1-vassilisamir@gmail.com
> v5: https://lore.kernel.org/linux-iio/20240902184222.24874-1-vassilisamir@gmail.com
> v4: https://lore.kernel.org/linux-iio/20240828205128.92145-1-vassilisamir@gmail.com
> v3: https://lore.kernel.org/linux-iio/20240823181714.64545-1-vassilisamir@gmail.com
> v2: https://lore.kernel.org/linux-iio/20240725231039.614536-1-vassilisamir@gmail.com
> v1: https://lore.kernel.org/linux-iio/20240711211558.106327-1-vassilisamir@gmail.com
> 
> Vasileios Amoiridis (4):
>   iio: pressure: bmp280: Use sleep and forced mode for oneshot captures
>   dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and
>     BMP5xx devices
>   iio: pressure: bmp280: Add data ready trigger support
>   iio: pressure: bmp280: Move bmp085 interrupt to new configuration
> 
>  .../bindings/iio/pressure/bmp085.yaml         |  22 +-
>  drivers/iio/pressure/bmp280-core.c            | 580 ++++++++++++++++--
>  drivers/iio/pressure/bmp280-i2c.c             |   4 +-
>  drivers/iio/pressure/bmp280-spi.c             |   4 +-
>  drivers/iio/pressure/bmp280.h                 |  43 ++
>  5 files changed, 612 insertions(+), 41 deletions(-)
> 
> 
> base-commit: fec496684388685647652ab4213454fbabdab099
> prerequisite-patch-id: e4f81f31f4fbb2aa872c0c74ed4511893eee0c9a