linux-kernel - Re: [PATCH 3/7] iio: light: veml6030: fix IIO device retrieval from embedded device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240914155130.2a3d0368@jic23-huawei>
Date: Sat, 14 Sep 2024 15:51:30 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Rishi Gupta <gupt21@...il.com>,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, stable@...r.kernel.org
Subject: Re: [PATCH 3/7] iio: light: veml6030: fix IIO device retrieval from
 embedded device

On Fri, 13 Sep 2024 15:18:58 +0200
Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:

> The dev pointer that is received as an argument in the
> in_illuminance_period_available_show function references the device
> embedded in the IIO device, not in the i2c client.
> 
> dev_to_iio_dev() must be used to accessthe right data. The current
> implementation leads to a segmentation fault on every attempt to read
> the attribute because indio_dev gets a NULL assignment.
> 
> This bug has been present since the first appearance of the driver,
> apparently since the last version (V6) before getting applied. A
> constant attribute was used until then, and the last modifications might
> have not been tested again.
> 
> Cc: stable@...r.kernel.org
> Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,
Jonathan

> ---
>  drivers/iio/light/veml6030.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 2e86d310952e..df2ba3078b91 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -99,9 +99,8 @@ static const char * const period_values[] = {
>  static ssize_t in_illuminance_period_available_show(struct device *dev,
>  				struct device_attribute *attr, char *buf)
>  {
> +	struct veml6030_data *data = iio_priv(dev_to_iio_dev(dev));
>  	int ret, reg, x;
> -	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> -	struct veml6030_data *data = iio_priv(indio_dev);
>  
>  	ret = regmap_read(data->regmap, VEML6030_REG_ALS_CONF, &reg);
>  	if (ret) {
>