linux-kernel - Re: [PATCH next] drm/tegra: Fix NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42bbc500-578c-474b-98ec-1988906f31ef@linux.intel.com>
Date: Sat, 14 Sep 2024 10:02:05 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: baolu.lu@...ux.intel.com, Thierry Reding <thierry.reding@...il.com>,
 Mikko Perttunen <mperttunen@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Jonathan Hunter <jonathanh@...dia.com>,
 Lyude Paul <lyude@...hat.com>, dri-devel@...ts.freedesktop.org,
 linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/tegra: Fix NULL vs IS_ERR() check in probe()

On 9/13/24 10:34 PM, Dan Carpenter wrote:
> The iommu_paging_domain_alloc() function doesn't  return NULL pointers,
> it returns error pointers.  Update the check to match.
> 
> Fixes: 45c690aea8ee ("drm/tegra: Use iommu_paging_domain_alloc()")
> Signed-off-by: Dan Carpenter<dan.carpenter@...aro.org>
> ---
>   drivers/gpu/drm/tegra/drm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>

Thanks,
baolu