linux-kernel - Re: [PATCH net-next] net: lan743x: clean up a check in lan743x_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240914154612.GG11774@kernel.org>
Date: Sat, 14 Sep 2024 16:46:12 +0100
From: Simon Horman <horms@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Bryan Whitehead <bryan.whitehead@...rochip.com>,
	Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>,
	UNGLinuxDriver@...rochip.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: lan743x: clean up a check in
 lan743x_netdev_open()

On Sat, Sep 14, 2024 at 12:59:01PM +0300, Dan Carpenter wrote:
> The "adapter->netdev->phydev" and "netdev->phydev" pointers are different
> names for the same thing.  Use them consistently.  It makes the code more
> clear to humans and static checkers alike.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Hi Dan,

net-next is currently closed, other than for bug fixes.
So please repost this once it re-opens, after v6.12-rc1 is released.

> ---
> I noticed a different static checker warning that I never reported because it
> was too old.  However, I think it's a valid issue.
> drivers/net/ethernet/microchip/lan743x_main.c:109 lan743x_pci_init() warn: missing error code 'ret'
> I think we should set an error code on that path.  It disables the PCI device
> and then we continue to do PCI stuff even though the device is disabled.

Yes, I agree.

I tend to think that is a bug. Though perhaps
there is no urgency in fixing it as it seems unlikely
to occur in practice and it seems to date back to when the
driver was added in 2018 / v4.17.

commit 23f0703c125b ("lan743x: Add main source files for new lan743x driver")

...

-- 
pw-bot: defer