linux-kernel - Re: [PATCH v2] staging: octeon: Use new initialization api for tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d9ff743-01bb-4b40-9551-fb220bf3c7f3@stanley.mountain>
Date: Sat, 14 Sep 2024 19:51:24 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Abhishek Tamboli <abhishektamboli9@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, skhan@...uxfoundation.org,
	rbmarliere@...il.com,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: octeon: Use new initialization api for
 tasklet

On Sat, Sep 14, 2024 at 10:14:56PM +0530, Abhishek Tamboli wrote:
> Hi Greg,
> 
> On Sat, Sep 14, 2024 at 10:20:02AM +0200, Greg KH wrote:
> > On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote:
> > > Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD
> > > introduced in commit 12cc923f1ccc ("tasklet: Introduce new
> > > initialization API").
> > 
> > This says what you are doing, but not why you are doing this.
> > 
> > Why is this needed?  What bug does this fix?  The code is the exact same
> > afterward so why should this be accepted?
> > 
>  While this patch doesn't fix any functional bug, it ensures that the 
>  code is kept up to date with the new Initialization API for tasklets.

You need to resend the patch with this information included in the commit
message.

regards,
dan carpenter