linux-kernel - Re: [PATCH v2 03/22] dt-bindings: cpufreq: apple,cluster-cpufreq: Add A10 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ebf5258-b55d-4010-aa94-d5bab1f93bb5@gmail.com>
Date: Sun, 15 Sep 2024 01:17:57 +0800
From: Nick Chan <towinchenmi@...il.com>
To: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
 Alyssa Rosenzweig <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "Rafael J . Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck
 <linux@...ck-us.net>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Mark Kettenis <kettenis@...nbsd.org>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-watchdog@...r.kernel.org
Cc: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH v2 03/22] dt-bindings: cpufreq: apple,cluster-cpufreq: Add
 A10 compatible

On 14/9/2024 13:17, Nick Chan wrote:
> The block found on the Apple A10 SoC is compatible with the
> existing driver so just add its per-SoC compatible.
> 
> Signed-off-by: Nick Chan <towinchenmi@...il.com>
> ---
>  .../devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml    | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> index 76cb9726660e..e0d1a9813696 100644
> --- a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml
> @@ -24,7 +24,9 @@ properties:
>                - apple,t8112-cluster-cpufreq
>            - const: apple,cluster-cpufreq
>        - items:
> -          - const: apple,t6000-cluster-cpufreq
> +          - enum:
> +              - apple,t8010-cluster-cpufreq
> +              - apple,t6000-cluster-cpufreq
>            - const: apple,t8103-cluster-cpufreq
>            - const: apple,cluster-cpufreq
>  

Have to retract the cpufreq patches, a v3 without them will be available
tomorrow. cpufreq works on iPad 7 (A10). However it is already pretty
weird when the cpufreq did not work on Apple TV 4K (A10X), with adjusted
p-states. However, it seems that iPhone 7 (A10) is also not working. So
this is definitely broken. As far as the hardware interfaces go they should
be compatible, so the only explanation that makes sense is that the behavior
is not correct on t8010 and t8011 and it only *happened* to work on iPad 7,
with some incorrect behaviors.

Marked as deferred on patchwork.

Nick Chan