linux-kernel - Re: [PATCH 01/21] arm64: Add ADI ADSP-SC598 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024091459-company-diabolic-a9ed@gregkh>
Date: Sat, 14 Sep 2024 19:56:09 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Arturs Artamonovs <Arturs.Artamonovs@...log.com>,
	Greg Malysa <greg.malysa@...esys.com>,
	Nathan Barrett-Morrison <nathan.morrison@...esys.com>,
	Utsav Agarwal <Utsav.Agarwal@...log.com>,
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
	linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
	soc@...nel.org, Andi Shyti <andi.shyti@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, Bartosz Golaszewski <brgl@...ev.pl>,
	Catalin Marinas <catalin.marinas@....com>,
	Conor Dooley <conor+dt@...nel.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Michael Turquette <mturquette@...libre.com>,
	Olof Johansson <olof@...om.net>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Rob Herring <robh@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Will Deacon <will@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, adsp-linux@...log.com
Subject: Re: [PATCH 01/21] arm64: Add ADI ADSP-SC598 SoC

On Sat, Sep 14, 2024 at 07:15:08PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/soc/adi/system.c
> > @@ -0,0 +1,257 @@
> …
> > +static void adi_system_config_remove(struct platform_device *pdev)
> +{
> > +	struct adi_system_config *config = platform_get_drvdata(pdev);
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&adi_system_config_lock, flags);
> > +	list_del(&config->list);
> > +	spin_unlock_irqrestore(&adi_system_config_lock, flags);
> > +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&adi_system_config_lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L572
> 
> Regards,
> Markus
> 


Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot