linux-kernel - Re: [PATCH] PCI: remove uneccessary if() and assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_RzfaM9BScunyGHmiiWTAG_TzybEfaxHOWYemcg47mix_X8w@mail.gmail.com>
Date: Sat, 14 Sep 2024 15:04:03 -0300
From: Guilherme Giácomo Simões <trintaeoitogc@...il.com>
To: bhelgaas@...gle.com
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: remove uneccessary if() and assignment

Guilherme Giacomo Simoes <trintaeoitogc@...il.com> wrotes:
>
> This second if is uneccesary, because, the first if is equals.
> The assignment os return pci_revert_fw_address() to ret variable is uneccessary to.
> Then, the second if() was removed and the return function is the return of pci_revert_fw_address()
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
> ---
>  drivers/pci/setup-res.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> index c6d933ddfd46..8ca1007cb6b3 100644
> --- a/drivers/pci/setup-res.c
> +++ b/drivers/pci/setup-res.c
> @@ -352,12 +352,7 @@ int pci_assign_resource(struct pci_dev *dev, int resno)
>          */
>         if (ret < 0) {
>                 pci_info(dev, "%s %pR: can't assign; no space\n", res_name, res);
> -               ret = pci_revert_fw_address(res, dev, resno, size);
> -       }
> -
> -       if (ret < 0) {
> -               pci_info(dev, "%s %pR: failed to assign\n", res_name, res);
> -               return ret;
> +               return pci_revert_fw_address(res, dev, resno, size);
>         }
>
>         res->flags &= ~IORESOURCE_UNSET;
> --
> 2.46.0
>

Please disregard this patch.