linux-kernel - Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240914-residence-buckwheat-26f10932ed6e@spud>
Date: Sat, 14 Sep 2024 23:24:15 +0100
From: Conor Dooley <conor@...nel.org>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
	ang.iglesiasg@...il.com, linus.walleij@...aro.org,
	biju.das.jz@...renesas.com, javier.carrasco.cruz@...il.com,
	semen.protsenko@...aro.org, 579lpy@...il.com, ak@...klinger.de,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v6 2/4] dt-bindings: iio: pressure: bmp085: Add
 interrupts for BMP3xx and BMP5xx devices

On Sat, Sep 14, 2024 at 01:59:49AM +0200, Vasileios Amoiridis wrote:
> On Fri, Sep 13, 2024 at 07:27:29PM +0100, Conor Dooley wrote:
> > On Fri, Sep 13, 2024 at 01:32:32AM +0200, Vasileios Amoiridis wrote:
> > > Add interrupt options for BMP3xx and BMP5xx devices as well.
> > > 
> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> > > ---
> > >  .../bindings/iio/pressure/bmp085.yaml         | 22 ++++++++++++++++++-
> > >  1 file changed, 21 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > index 6fda887ee9d4..7c9d85be9008 100644
> > > --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml
> > > @@ -48,14 +48,34 @@ properties:
> > >  
> > >    interrupts:
> > >      description:
> > > -      interrupt mapping for IRQ (BMP085 only)
> > > +      interrupt mapping for IRQ. Supported in BMP085, BMP3xx, BMP5xx
> > 
> > If you respin, you can drop the description entirely, since you've added
> > proper enforcement below.
> > 
> > Otherwise,
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> Thanks for the time to review this, I will try to see if I can do it
> tonight, thanks!

I think I am "too late" in saying this, but I was not expecting a respin
for this change, but only for the change to be made if you were
respinning for another reason.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)