linux-kernel - Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172628343575.2438539.17479638997726025148.git-patchwork-notify@kernel.org>
Date: Sat, 14 Sep 2024 03:10:35 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Brett Creeley <brett.creeley@....com>
Cc: alexanderduyck@...com, kuba@...nel.org, kernel-team@...a.com,
 davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, jdamato@...tly.com, stable@...r.kernel.org
Subject: Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi_add

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 12 Sep 2024 10:49:22 -0700 you wrote:
> The driver calls netif_napi_set_irq() and then calls netif_napi_add(),
> which calls netif_napi_add_weight(). At the end of
> netif_napi_add_weight() is a call to netif_napi_set_irq(napi, -1), which
> clears the previously set napi->irq value. Fix this by calling
> netif_napi_set_irq() after calling netif_napi_add().
> 
> This was found when reviewing another patch and I have no way to test
> this, but the fix seemed relatively straight forward.
> 
> [...]

Here is the summary with links:
  - [net] fbnic: Set napi irq value after calling netif_napi_add
    https://git.kernel.org/netdev/net/c/9f3e7f11f21a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html