linux-kernel - Re: [PATCH V10 net-next 06/10] net: hibmcge: Implement .ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240915170828.60f866f1@kernel.org>
Date: Sun, 15 Sep 2024 17:08:28 +0200
From: Jakub Kicinski <kuba@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
 <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
 <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
 <shiyongbang@...wei.com>, <libaihan@...wei.com>, <andrew@...n.ch>,
 <jdamato@...tly.com>, <horms@...nel.org>,
 <kalesh-anakkur.purayil@...adcom.com>, <jonathan.cameron@...wei.com>,
 <shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V10 net-next 06/10] net: hibmcge: Implement
 .ndo_start_xmit function

On Thu, 12 Sep 2024 10:51:23 +0800 Jijie Shao wrote:
> +struct hbg_priv;
> +struct hbg_ring;

these are unnecessary, use as struct member automatically fwd declares

> +struct hbg_buffer {
> +	u32 state;
> +	dma_addr_t state_dma;
> +
> +	struct sk_buff *skb;
> +	dma_addr_t skb_dma;
> +	u32 skb_len;
> +
> +	enum hbg_dir dir;
> +	struct hbg_ring *ring;
> +	struct hbg_priv *priv;
> +};