linux-kernel - Re: [PATCH V10 net-next 06/10] net: hibmcge: Implement .ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4bcd1e2-6e46-4636-bc10-37f4adcdb868@wanadoo.fr>
Date: Sun, 15 Sep 2024 17:52:58 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Jijie Shao <shaojijie@...wei.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: shenjian15@...wei.com, wangpeiyang1@...wei.com, liuyonglong@...wei.com,
 chenhao418@...wei.com, sudongming1@...wei.com, xujunsheng@...wei.com,
 shiyongbang@...wei.com, libaihan@...wei.com, andrew@...n.ch,
 jdamato@...tly.com, horms@...nel.org, kalesh-anakkur.purayil@...adcom.com,
 jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
 salil.mehta@...wei.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V10 net-next 06/10] net: hibmcge: Implement
 .ndo_start_xmit function

Le 12/09/2024 à 04:51, Jijie Shao a écrit :
> Implement .ndo_start_xmit function to fill the information of the packet
> to be transmitted into the tx descriptor, and then the hardware will
> transmit the packet using the information in the tx descriptor.
> In addition, we also implemented the tx_handler function to enable the
> tx descriptor to be reused, and .ndo_tx_timeout function to print some
> information when the hardware is busy.
> 
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

...

> +static int hbg_dma_map(struct hbg_buffer *buffer)
> +{
> +	struct hbg_priv *priv = buffer->priv;
> +
> +	buffer->skb_dma = dma_map_single(&priv->pdev->dev,
> +					 buffer->skb->data, buffer->skb_len,
> +					 buffer_to_dma_dir(buffer));
> +	if (unlikely(dma_mapping_error(&priv->pdev->dev, buffer->skb_dma)))

I don't think that the unlikely() is needed.

Maybe some other ones are also not needed when in slow path.

> +		return -ENOMEM;
> +
> +	return 0;
> +}

...

> +static int hbg_tx_ring_init(struct hbg_priv *priv)
> +{
> +	struct hbg_ring *tx_ring = &priv->tx_ring;
> +
> +	if (!tx_ring->tout_log_buf)
> +		tx_ring->tout_log_buf = devm_kzalloc(&priv->pdev->dev,
> +						     HBG_TX_TIMEOUT_BUF_LEN,
> +						     GFP_KERNEL);

Nitpick: devm_kmalloc() looks enough.
It is zeroed only the first time we get there anyway.

> +
> +	if (!tx_ring->tout_log_buf)
> +		return -ENOMEM;
> +
> +	return hbg_ring_init(priv, tx_ring, hbg_napi_tx_recycle, HBG_DIR_TX);
> +}