linux-kernel - [PATCH] ASoC: mc13783: Use scope-based resource management in mc13783_codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <21094235-3f45-4a67-a463-7b4658b9ee06@web.de>
Date: Sun, 15 Sep 2024 21:50:39 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-sound@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Takashi Iwai <tiwai@...e.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Julia Lawall <julia.lawall@...ia.fr>
Subject: [PATCH] ASoC: mc13783: Use scope-based resource management in
 mc13783_codec_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sun, 15 Sep 2024 21:41:00 +0200

Scope-based resource management became supported also for another
programming interface by contributions of Jonathan Cameron on 2024-02-25.
See also the commit 9448e55d032d99af8e23487f51a542d51b2f1a48 ("of:
Add cleanup.h based auto release via __free(device_node) markings").

* Thus use the attribute “__free(device_node)”.

* Reduce the scope for the local variable “np”.

* Omit explicit of_node_put() calls accordingly.


This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 sound/soc/codecs/mc13783.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
index 086ac97e8386..ed894bfc6a1c 100644
--- a/sound/soc/codecs/mc13783.c
+++ b/sound/soc/codecs/mc13783.c
@@ -733,7 +733,6 @@ static int __init mc13783_codec_probe(struct platform_device *pdev)
 {
 	struct mc13783_priv *priv;
 	struct mc13xxx_codec_platform_data *pdata = pdev->dev.platform_data;
-	struct device_node *np;
 	int ret;

 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
@@ -744,23 +743,18 @@ static int __init mc13783_codec_probe(struct platform_device *pdev)
 		priv->adc_ssi_port = pdata->adc_ssi_port;
 		priv->dac_ssi_port = pdata->dac_ssi_port;
 	} else {
-		np = of_get_child_by_name(pdev->dev.parent->of_node, "codec");
+		struct device_node *np __free(device_node)
+				       = of_get_child_by_name(pdev->dev.parent->of_node, "codec");
 		if (!np)
 			return -ENOSYS;

 		ret = of_property_read_u32(np, "adc-port", &priv->adc_ssi_port);
-		if (ret) {
-			of_node_put(np);
+		if (ret)
 			return ret;
-		}

 		ret = of_property_read_u32(np, "dac-port", &priv->dac_ssi_port);
-		if (ret) {
-			of_node_put(np);
+		if (ret)
 			return ret;
-		}
-
-		of_node_put(np);
 	}

 	dev_set_drvdata(&pdev->dev, priv);
--
2.46.0