linux-kernel - Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8734m1mouw.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sun, 15 Sep 2024 11:37:35 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Danny Tsen <dtsen@...ux.ibm.com>, <linux-crypto@...r.kernel.org>
CC: <herbert@...dor.apana.org.au>, <leitao@...ian.org>, <nayna@...ux.ibm.com>,
        <appro@...ptogams.org>, <linux-kernel@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <ltcgcw@...ux.vnet.ibm.com>,
        <dtsen@...ibm.com>, Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel
 encrypted/decrypted with ppc64le AES/GCM module.

Danny Tsen <dtsen@...ux.ibm.com> writes:

> Yes, checkpath was run.

As you're splitting the patches anyways, this may not be
needed anymore, but below is guideline for subject line.

https://docs.kernel.org/process/submitting-patches.html

"For these reasons, the summary must be no more than 70-75 characters,
and it must describe both what the patch changes, as well as why the
patch might be necessary.
It is challenging to be both succinct and descriptive, but that is what
a well-written summary should do."

I guess check patch is not checking that.

Also avoid top posting,

Read "Use trimmed interleaved replies in email discussions" from above
document.

Kamlesh

>
> Not sure what you mean by "some indentation changes.(This can't go with 
> fixes patch, will just add the noise)"
>
> Thanks.
>
...
>>> As this is a bug fix it should have a Fixes: tag, and probably a stable
>>> Cc as well.
>>>
>>> But that diffstat is really large for a bug fix. Is there no way to fix
>>> the issue in a smaller patch? Even if that is just disabling the feature
>>> until it can be fixed in subsequent commits?
>>>
>>> cheers
>> The commit message says "The fix is to register algs as SIMD modules"
>>
>> and
>>
>> "A new module rfc4106(gcm(aes)) is also added."
>>
>> and I also see some indentation changes.(This can't go with fixes patch,
>> will just add the noise)
>>
>> Would suggest to break the patch in three.
>>
>> I see a big subject line, have you ran the checkpatch?
>>
>> Kamlesh
>>