linux-kernel - Re: [PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OGNOfDkpGumipdpwJBCa1_UCB0NHQQ5otnPrH9b=_V8Q@mail.gmail.com>
Date: Mon, 16 Sep 2024 17:22:08 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: linux@...blig.org
Cc: harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com, 
	alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display: Remove unused function bios_get_vga_enabled_displays

Acked-by: Alex Deucher <alexander.deucher@....com>

And applied.

Thanks!

On Sun, Sep 15, 2024 at 10:19 AM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> bios_get_vga_enabled_displays has been unused since
>   commit 5a8132b9f606 ("drm/amd/display: remove dead dc vbios code")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c | 7 -------
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h | 1 -
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> index adc710fe4a45..8d2cf95ae739 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c
> @@ -78,10 +78,3 @@ void bios_set_scratch_critical_state(
>         uint32_t critial_state = state ? 1 : 0;
>         REG_UPDATE(BIOS_SCRATCH_6, S6_CRITICAL_STATE, critial_state);
>  }
> -
> -uint32_t bios_get_vga_enabled_displays(
> -       struct dc_bios *bios)
> -{
> -       return REG_READ(BIOS_SCRATCH_3) & 0XFFFF;
> -}
> -
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> index e1b4a40a353d..ab162f2fe577 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.h
> @@ -34,7 +34,6 @@ uint8_t *bios_get_image(struct dc_bios *bp, uint32_t offset,
>  bool bios_is_accelerated_mode(struct dc_bios *bios);
>  void bios_set_scratch_acc_mode_change(struct dc_bios *bios, uint32_t state);
>  void bios_set_scratch_critical_state(struct dc_bios *bios, bool state);
> -uint32_t bios_get_vga_enabled_displays(struct dc_bios *bios);
>
>  #define GET_IMAGE(type, offset) ((type *) bios_get_image(&bp->base, offset, sizeof(type)))
>
> --
> 2.46.0
>