linux-kernel - Re: [PATCH -next] drm/msm: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13f79bfe-a67a-475c-9c1f-dbff802242eb@quicinc.com>
Date: Mon, 16 Sep 2024 15:33:36 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Yang Li <yang.lee@...ux.alibaba.com>, <robdclark@...il.com>,
        <dmitry.baryshkov@...aro.org>, <airlied@...il.com>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Abaci
 Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] drm/msm: Remove unneeded semicolon



On 9/2/2024 5:56 PM, Yang Li wrote:
> ./drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c:282:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9852
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Change looks fine but can you pls have a short one line in the commit 
text instead of just pasting the error from the errorchecker?

> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> index 0e3a2b16a2ce..65cf237c6b4e 100644
> --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c
> @@ -279,7 +279,7 @@ static int pll_get_post_div(struct hdmi_8998_post_divider *pd, u64 bclk)
>   	case 25:
>   		found_hsclk_divsel = 14;
>   		break;
> -	};
> +	}
>   
>   	pd->vco_freq = found_vco_freq;
>   	pd->tx_band_sel = found_tx_band_sel;