linux-kernel - Re: [PATCH v2] dt-bindings: serial: rs485: Fix rs485-rts-delay property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e832247-f6b6-49a2-a76a-17467c3243a5@amd.com>
Date: Mon, 16 Sep 2024 07:55:52 +0200
From: Michal Simek <michal.simek@....com>
To: Conor Dooley <conor@...nel.org>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, stable@...r.kernel.org,
 Benjamin Gaignard <benjamin.gaignard@...com>,
 Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Rob Herring <robh@...nel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "open list:TTY LAYER AND SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: serial: rs485: Fix rs485-rts-delay
 property



On 9/13/24 19:24, Conor Dooley wrote:
> On Fri, Sep 13, 2024 at 12:55:23PM +0200, Michal Simek wrote:
>> Code expects array only with 2 items which should be checked.
>> But also item checking is not working as it should likely because of
>> incorrect items description.
>>
>> Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema")
>> Signed-off-by: Michal Simek <michal.simek@....com>
>> Cc: <stable@...r.kernel.org>
>> ---
>>
>> Changes in v2:
>> - Remove maxItems properties which are not needed
>> - Add stable ML to CC
>>
>>   .../devicetree/bindings/serial/rs485.yaml     | 19 +++++++++----------
>>   1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
>> index 9418fd66a8e9..9665de41762e 100644
>> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
>> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
>> @@ -18,16 +18,15 @@ properties:
>>       description: prop-encoded-array <a b>
>>       $ref: /schemas/types.yaml#/definitions/uint32-array
>>       items:
>> -      items:
>> -        - description: Delay between rts signal and beginning of data sent in
>> -            milliseconds. It corresponds to the delay before sending data.
>> -          default: 0
>> -          maximum: 100
>> -        - description: Delay between end of data sent and rts signal in milliseconds.
>> -            It corresponds to the delay after sending data and actual release
>> -            of the line.
>> -          default: 0
>> -          maximum: 100
>> +      - description: Delay between rts signal and beginning of data sent in
>> +          milliseconds. It corresponds to the delay before sending data.
>> +        default: 0
>> +        maximum: 50
> 
> I would expect to see some mention in the commit message as to why the
> maximum has changed from 100 to 50 milliseconds.

grrr. I was playing with setting up different values and check if checking is 
working. That should be still 100. No reason for value change.
Will fix in v3.

M