linux-kernel - Re: [PATCH] arm64: dts: qcom: sa8775p: add DisplayPort device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2d3d18f-f671-4616-a722-2e41c8e50939@kernel.org>
Date: Tue, 17 Sep 2024 01:35:39 +0200
From: Konrad Dybcio <konradybcio@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Soutrik Mukhopadhyay <quic_mukhopad@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_riteshk@...cinc.com, quic_vproddut@...cinc.com,
 quic_abhinavk@...cinc.com
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: add DisplayPort device node

On 16.09.2024 4:01 PM, Dmitry Baryshkov wrote:
> On Mon, Sep 16, 2024 at 02:43:44PM GMT, Soutrik Mukhopadhyay wrote:
>> Add device tree node for the DisplayPort controller
>> and eDP PHY found on the Qualcomm SA8775P SoC.
> 
> Not quite. You are also enabling it for the RIDE platforms, not just the
> SA8775p SoC.

(the patches should be split into soc and board parts)

[...]

>> +				ports {
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +
>> +					port@0 {
>> +						reg = <0>;
>> +						dpu_intf0_out: endpoint {

Please add a newline between the last property and the subnode

Konrad