linux-kernel - Re: [RFC PATCH 2/3] crypto: add by_n attribute to acomp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4xREUbRWRZEO8EiEBdP9YN0Wip4_p58Cca=B4ZdPb7Mpg@mail.gmail.com>
Date: Mon, 16 Sep 2024 14:16:20 +0800
From: Barry Song <21cnbao@...il.com>
To: Andre Glover <andre.glover@...ux.intel.com>
Cc: tom.zanussi@...ux.intel.com, minchan@...nel.org, senozhatsky@...omium.org, 
	hannes@...xchg.org, yosryahmed@...gle.com, nphamcs@...il.com, 
	chengming.zhou@...ux.dev, herbert@...dor.apana.org.au, davem@...emloft.net, 
	fenghua.yu@...el.com, dave.jiang@...el.com, wajdi.k.feghali@...el.com, 
	james.guilford@...el.com, vinodh.gopal@...el.com, bala.seshasayee@...el.com, 
	heath.caldwell@...el.com, kanchana.p.sridhar@...el.com, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, ryan.roberts@....com, 
	linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [RFC PATCH 2/3] crypto: add by_n attribute to acomp_req

On Thu, May 2, 2024 at 5:46 AM Andre Glover
<andre.glover@...ux.intel.com> wrote:
>
> Add the 'by_n' attribute to the acomp_req. The 'by_n' attribute can be
> used a directive by acomp crypto algorithms for splitting compress and
> decompress operations into "n" separate jobs.

Hi Andre,

I am definitely in favor of the patchset idea. However, I'm not convinced that a
separate by_n API is necessary. Couldn’t this functionality be handled
automatically within your driver? For instance, if a large folio is detected,
could it automatically apply the by_n concept?

Am I overlooking something that makes exposing the API necessary in
this case?

>
> Signed-off-by: Andre Glover <andre.glover@...ux.intel.com>
> ---
>  include/crypto/acompress.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
> index 2b73cef2f430..c687729e1966 100644
> --- a/include/crypto/acompress.h
> +++ b/include/crypto/acompress.h
> @@ -25,6 +25,7 @@
>   * @slen:      Size of the input buffer
>   * @dlen:      Size of the output buffer and number of bytes produced
>   * @flags:     Internal flags
> + * @by_n:      by_n setting used by acomp alg
>   * @__ctx:     Start of private context data
>   */
>  struct acomp_req {
> @@ -34,6 +35,7 @@ struct acomp_req {
>         unsigned int slen;
>         unsigned int dlen;
>         u32 flags;
> +       u32 by_n;
>         void *__ctx[] CRYPTO_MINALIGN_ATTR;
>  };
>
> --
> 2.27.0
>

Thanks
Barry