[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b1e35953-da11-475a-ada5-794ee04624f7@kernel.org>
Date: Mon, 16 Sep 2024 08:53:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: arturs.artamonovs@...log.com, Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>, Greg Malysa <greg.malysa@...esys.com>,
Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Utsav Agarwal <Utsav.Agarwal@...log.com>,
Michael Turquette <mturquette@...libre.com>, Stephen Boyd
<sboyd@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>, Thomas Gleixner <tglx@...utronix.de>,
Andi Shyti <andi.shyti@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Olof Johansson <olof@...om.net>, soc@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-serial@...r.kernel.org, adsp-linux@...log.com,
Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Subject: Re: [PATCH 10/21] dt-bindings: gpio: adi,adsp-port-gpio: add bindings
On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote:
> From: Arturs Artamonovs <arturs.artamonovs@...log.com>
>
> Add ADSP-SC5xx GPIO driver bindings.
>
> Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@...log.com>
> Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@...esys.com>
> Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@...esys.com>
> Co-developed-by: Greg Malysa <greg.malysa@...esys.com>
> Signed-off-by: Greg Malysa <greg.malysa@...esys.com>
> ---
> .../bindings/gpio/adi,adsp-port-gpio.yaml | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/adi,adsp-port-gpio.yaml b/Documentation/devicetree/bindings/gpio/adi,adsp-port-gpio.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..3d7899ce759193296ce787d09d742824277f37f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/adi,adsp-port-gpio.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/adi,adsp-port-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices GPIO Port Driver for SC5XX-family processors
> +
> +maintainers:
> + - Arturs Artamonovs <arturs.artamonovs@...log.com>
> + - Utsav Agarwal <Utsav.Agarwal@...log.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
All review comments apply to all your patches.
> + Analog Devices GPIO Port Driver for SC5XX-family processors
> +
> +properties:
> + compatible:
> + enum:
> + - adi,adsp-port-gpio
No, this *must* be SoC-specific compatible. If you are unsure, just look
at any other SoC (of course nothing ancient).
> +
> + gpio-controller: true
> +
> + "#gpio-cells":
> + const: 2
> +
> + gpio-ranges:
> + description: Associated pinmux controller and the GPIO range values
That's useless comment. Just true, or min/maxItems
> +
> + adi,pint:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: Associated pin interrupt controller driver
> + items:
> + - items:
> + - description: phandle to pin interrupt controller driver
> + - description: interrupt value
Hm? No, why would you put it here? And why this is not just interrupts
property?
> +
> + reg:
> + description: PORT GPIO control registers
Reg goes after compatible
> +
> +required:
> + - compatible
> + - reg
Look, here order is correct.
> + - "#gpio-cells"
> + - gpio-controller
> + - gpio-ranges
> + - adi,pint
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpa: gport@...04000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Drop unused label.
> + compatible = "adi,adsp-port-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + reg = <0x31004000 0x7F>;
It is ALWAYS lowercase hex. This applies (just like all other comments)
to all your DT-related code.
> + gpio-ranges = <&pinctrl0 0 0 16>;
> + adi,pint = <&pint0 1>;
Just one example. Drop the one below.
> + };
> +
> + gpb: gport@...04080 {
> + compatible = "adi,adsp-port-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + reg = <0x31004080 0x7F>;
> + gpio-ranges = <&pinctrl0 0 16 16>;
> + adi,pint = <&pint0 0>;
> + };
> +...
>
Best regards,
Krzysztof
Powered by blists - more mailing lists