linux-kernel - Re: [PATCH] ARM: dts: microchip: Add trng labels for all at91 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67d0e60f-718f-4496-bb7f-aa5180291cfd@microchip.com>
Date: Mon, 16 Sep 2024 09:23:57 +0200
From: Nicolas Ferre <nicolas.ferre@...rochip.com>
To: Alexander Dahl <ada@...rsis.com>, Conor Dooley <conor+dt@...nel.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE
 TREE BINDINGS" <devicetree@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>, linux-arm-kernel
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: microchip: Add trng labels for all at91 SoCs

Hi Alexander,

On 16/09/2024 at 08:42, Alexander Dahl wrote:
> SAM9X60 and SAMA7G5 already have those labels.  Add it for the other SoC
> families so it can be referenced in board files.
> 
> Signed-off-by: Alexander Dahl <ada@...rsis.com>

Thanks for the patch.

While we are at it, now that we have a proper label, can you please 
change the node name which should be "rng" ?

It will be aligned with latest Device Tree specification and what we 
tried to follow for newer sama7g5 for instance:

https://elixir.bootlin.com/linux/v6.10.10/source/arch/arm/boot/dts/microchip/sama7g5.dtsi#L774

Best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/microchip/at91sam9g45.dtsi | 2 +-
>   arch/arm/boot/dts/microchip/sama5d2.dtsi     | 2 +-
>   arch/arm/boot/dts/microchip/sama5d3.dtsi     | 2 +-
>   arch/arm/boot/dts/microchip/sama5d4.dtsi     | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> index 325c63a53118..02bd5a1833e8 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/microchip/at91sam9g45.dtsi
> @@ -753,7 +753,7 @@ macb0: ethernet@...bc000 {
>                                  status = "disabled";
>                          };
> 
> -                       trng@...cc000 {
> +                       trng: trng@...cc000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfffcc000 0x100>;
>                                  interrupts = <6 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d2.dtsi b/arch/arm/boot/dts/microchip/sama5d2.dtsi
> index 5f8e297e19ed..2fefe3efa769 100644
> --- a/arch/arm/boot/dts/microchip/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d2.dtsi
> @@ -1019,7 +1019,7 @@ AT91_XDMAC_DT_PER_IF(1) |
>                                  };
>                          };
> 
> -                       trng@...1c000 {
> +                       trng: trng@...1c000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfc01c000 0x100>;
>                                  interrupts = <47 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d3.dtsi b/arch/arm/boot/dts/microchip/sama5d3.dtsi
> index d4fc0c1dfc10..8335e0c8066f 100644
> --- a/arch/arm/boot/dts/microchip/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d3.dtsi
> @@ -419,7 +419,7 @@ tdes: crypto@...3c000 {
>                                  clock-names = "tdes_clk";
>                          };
> 
> -                       trng@...40000 {
> +                       trng: trng@...40000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xf8040000 0x100>;
>                                  interrupts = <45 IRQ_TYPE_LEVEL_HIGH 0>;
> diff --git a/arch/arm/boot/dts/microchip/sama5d4.dtsi b/arch/arm/boot/dts/microchip/sama5d4.dtsi
> index 58ceed997889..20b8a9b123e1 100644
> --- a/arch/arm/boot/dts/microchip/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/microchip/sama5d4.dtsi
> @@ -658,7 +658,7 @@ macb1: ethernet@...28000 {
>                                  status = "disabled";
>                          };
> 
> -                       trng@...30000 {
> +                       trng: trng@...30000 {
>                                  compatible = "atmel,at91sam9g45-trng";
>                                  reg = <0xfc030000 0x100>;
>                                  interrupts = <53 IRQ_TYPE_LEVEL_HIGH 0>;
> 
> base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652
> --
> 2.39.5
>