linux-kernel - Re: [PATCH v2] Fix spelling errors in file drivers/usb/gadget/udc/m66592-udc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024091606-armoire-lyrics-5bf8@gregkh>
Date: Mon, 16 Sep 2024 09:40:45 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: "Everest K.C." <everestkc@...restkc.com.np>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Fix spelling errors in file
 drivers/usb/gadget/udc/m66592-udc.c

On Mon, Sep 16, 2024 at 01:35:19AM -0600, Everest K.C. wrote:
> On Mon, Sep 16, 2024 at 12:52 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Sun, Sep 15, 2024 at 11:23:56PM -0600, Everest K.C. wrote:
> > > Fixed spelling errors in error message and comments that
> > > were reported by codespell as follows:
> > >       unexpect  --> unexpected
> > >       workaound --> workaround
> > >
> > > Signed-off-by: Everest K.C. <everestkc@...restkc.com.np>
> > > ---
> > >  v1 --> v2: Removed the coding style fix. This patch now only
> > >           fixes spelling errors. The coding style will be fixed
> > >           in a separate patch.
> > >
> > >  drivers/usb/gadget/udc/m66592-udc.c | 18 +++++++++---------
> >
> > If you do:
> >         git log --oneline drivers/usb/gadget/udc/m66592-udc.c
> > you will see the format for how to properly write the Subject: line
> > here.
> >
> > As this is your first kernel contributions, I recommend working in an
> > area that is designed for new developers to help work through these
> > types of issues, drivers/staging/  Get some experience there before
> > moving out into other areas of the kernel.  Also note that many
> > subsystems do not care about things like spelling fixes, so be careful.
> >
> > thanks,
> >
> > greg k-h
> 
> Hi Greg,
> Thank you for pointing out my mistake with the subject line. I have noted
> and will keep that in mind when I submit my next patch.
> Also, do you mean the fixes like this need to be done in gregkh/staging.git
> repo? Do you recommend that I resubmit this patch with corrections or
> discard it ?

I mean start working in drivers/staging/ on issues there, not in
drivers/usb/, until you get the process working well for you, then worry
about moving to other portions of the kernel.

good luck!

greg k-h