linux-kernel - Re: [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6be27228-a8ed-4346-a819-3a9d4b1441fa@oss.nxp.com>
Date: Mon, 16 Sep 2024 11:14:47 +0300
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Ghennadi Procopciuc <ghennadi.procopciuc@....com>,
 Larisa Grigore <larisa.grigore@....com>, Phu Luu An <phu.luuan@....com>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Bartosz Golaszewski <brgl@...ev.pl>,
 Chester Lin <chester62515@...il.com>, Conor Dooley <conor+dt@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>,
 Matthias Brugger <mbrugger@...e.com>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, s32@....com
Subject: Re: [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs
 support

Hi Markus,

On 14/09/2024 19:40, Markus Elfring wrote:
> …
>> +++ b/drivers/gpio/gpio-siul2-s32g2.c
>> @@ -0,0 +1,581 @@
> …
>> +static void siul2_gpio_set_direction(struct siul2_gpio_dev *dev,
>> +				     unsigned int gpio, int dir)
>> +{
>> +	unsigned long flags;
>> +
>> +	raw_spin_lock_irqsave(&dev->lock, flags);
> …
>> +	raw_spin_unlock_irqrestore(&dev->lock, flags);
>> +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(raw_spinlock_irqsave)(&dev->lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc7/source/include/linux/spinlock.h#L551

Thank you very much for the suggestion! I will add it in v3.

> 
> Regards,
> Markus

Best regards,
Andrei