linux-kernel - Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for QCM6490 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dec532c-b6b3-4c69-8f8f-21b3c45fcf3a@kernel.org>
Date: Mon, 16 Sep 2024 10:40:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Taniya Das <quic_tdas@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 quic_imrashai@...cinc.com, quic_jkona@...cinc.com
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: qcom: Add compatible for
 QCM6490 boards

On 13/09/2024 07:18, Taniya Das wrote:
> 
> 
> On 8/17/2024 2:51 PM, Krzysztof Kozlowski wrote:
>> On 16/08/2024 10:32, Taniya Das wrote:
>>> Add the new QCM6490 compatible to support the reset functionality for
>>> Low Power Audio subsystem.
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>>
>> Subject is odd - I do not see here anything related to boards.
>>
>> Anyway, this is incomplete. Look at the rest of the binding - you did
>> not update any part related to proper clock constraints.
>>
> 
> Not sure if I understand the concern, but I was of the opinion that I 
> have added a new compatible for QCM6490 board , but no new clock 
> constraint added.
> 
> 
> I see a patch from you 
> https://lore.kernel.org/all/20240817094605.27185-1-krzysztof.kozlowski@linaro.org/ 
> and I guess it fixes the constraints.
> 

Look at entire file. This is incomplete.

Best regards,
Krzysztof