linux-kernel - Re: [PATCH 1/3] dt-bindings: hwmon: pmbus: add ti tps25990 documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9035e0e1-ea47-4f40-b0d1-38dc4d80acee@kernel.org>
Date: Mon, 16 Sep 2024 10:45:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>, linux-hwmon@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: hwmon: pmbus: add ti tps25990
 documentation

On 10/09/2024 11:31, Jerome Brunet wrote:
>>> +
>>> +  interrupts:
>>> +    description: PMBUS SMB Alert Interrupt.
>>> +    maxItems: 1
>>> +
>>> +  regulators:
>>> +    type: object
>>> +    description:
>>> +      list of regulators provided by this controller.
>>
>> You have just one regulator, so drop "regulators" node and use directly
>> vout here.
> 
> Just took the example the other pmbus device and did the same for
> consistency.
> 
> In that case, there other (possible) regulator called gpdac1 and gpdac2.
> I haven't even tried to implement the support for those.

Your binding should be complete. Does not matter whether you implemented
it in drivers or not.

> 
> Since it would not break old DTs to add that later, I thought it would be OK
> to add them later. Should I add them now ?

This should be added now.



Best regards,
Krzysztof