linux-kernel - Re: [PATCH v2 1/5] iommu/vt-d: Separate page request queue from SVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240916092422.lasp556wb57em7hz@joelS2.panther.com>
Date: Mon, 16 Sep 2024 11:24:22 +0200
From: Joel Granados <j.granados@...sung.com>
To: "Tian, Kevin" <kevin.tian@...el.com>
CC: David Woodhouse <dwmw2@...radead.org>, Lu Baolu
	<baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>, Will Deacon
	<will@...nel.org>, Robin Murphy <robin.murphy@....com>, Jason Gunthorpe
	<jgg@...pe.ca>, Klaus Jensen <its@...elevant.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>
Subject: Re: [PATCH v2 1/5] iommu/vt-d: Separate page request queue from SVM

On Sat, Sep 14, 2024 at 12:52:22AM +0000, Tian, Kevin wrote:
> > From: Joel Granados via B4 Relay
> > <devnull+j.granados.samsung.com@...nel.org>
> > 
> > From: Joel Granados <j.granados@...sung.com>
> > 
> > IO page faults are no longer dependent on CONFIG_INTEL_IOMMU_SVM.
> > Move
> > all Page Request Queue (PRQ) functions that handle prq events to a new
> > file in drivers/iommu/intel/prq.c. The page_req_des struct is now
> > declared in drivers/iommu/intel/prq.c.
> > 
> > No functional changes are intended. This is a preparation patch to
> > enable the use of IO page faults outside the SVM/PASID use cases.
> 
> Do we want to guard it under a new config option e.g.
> CONFIG_INTEL_IOMMU_IOPF? it's unnecessary to allocate resources
> for the majority usages which don't require IOPF.
> 
> Baolu?
> 
> > -#ifdef CONFIG_INTEL_IOMMU_SVM
> >  	if (pasid_supported(iommu)) {
> >  		if (ecap_prs(iommu->ecap))
> > -			intel_svm_finish_prq(iommu);
> > +			intel_finish_prq(iommu);
> >  	}
> > -#endif
> 
> either intel_iommu_finish_prq() or intel_prq_finish().

Thx; I see the pattern now! The first (Adding "_iommu_" to the name)
makes more sense to me as I see some intel_iommu_* function further down
in the iommu.h file.

> 
> same for other helpers.

Will change for the next version

Best

-- 

Joel Granados