[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a22e095c-d0fb-4414-8a4b-eea86bb90d02@suse.de>
Date: Mon, 16 Sep 2024 13:32:32 +0300
From: Stanimir Varbanov <svarbanov@...e.de>
To: Rob Herring <robh@...nel.org>, Stanimir Varbanov <svarbanov@...e.de>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-rpi-kernel@...ts.infradead.org,
linux-pci@...r.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>, Thomas Gleixner
<tglx@...utronix.de>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Jim Quinlan <jim2101024@...il.com>,
Nicolas Saenz Julienne <nsaenz@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>, kw@...ux.com,
Philipp Zabel <p.zabel@...gutronix.de>,
Andrea della Porta <andrea.porta@...e.com>,
Phil Elwell <phil@...pberrypi.com>, Jonathan Bell <jonathan@...pberrypi.com>
Subject: Re: [PATCH v2 -next 01/11] dt-bindings: interrupt-controller: Add
bcm2712 MSI-X DT bindings
Hi Rob,
Thank you for the review comments!
On 9/11/24 19:56, Rob Herring wrote:
> On Tue, Sep 10, 2024 at 06:18:35PM +0300, Stanimir Varbanov wrote:
>> Adds DT bindings for bcm2712 MSI-X interrupt peripheral controller.
>>
>> Signed-off-by: Stanimir Varbanov <svarbanov@...e.de>
>> ---
>> .../brcm,bcm2712-msix.yaml | 69 +++++++++++++++++++
>> 1 file changed, 69 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml
>> new file mode 100644
>> index 000000000000..2b53dfa7c25e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml
>> @@ -0,0 +1,69 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/interrupt-controller/brcm,bcm2712-msix.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Broadcom bcm2712 MSI-X Interrupt Peripheral support
>> +
>> +maintainers:
>> + - Stanimir Varbanov <svarbanov@...e.de>
>> +
>> +description: >
>
> Don't need '>' here.
OK.
>
>> + This interrupt controller is used to provide interrupt vectors to the
>> + generic interrupt controller (GIC) on bcm2712. It will be used as
>> + external MSI-X controller for PCIe root complex.
>> +
>> +allOf:
>> + - $ref: /schemas/interrupt-controller/msi-controller.yaml#
>> +
>> +properties:
>> + compatible:
>> + const: brcm,bcm2712-mip
>> +
>> + reg:
>> + items:
>> + - description: base registers address
>> + - description: pcie message address
>> +
>> + interrupt-controller: true
>> +
>> + "#interrupt-cells":
>> + const: 2
>
> What goes in these cells?
>
> But really, what interrupts does an MSI controller handle? Or are we
> just putting "interrupt-controller" in here so that kernel handles this
> with IRQCHIP_DECLARE()?
>
Yes, looks like interrupt-controller property is need by IRQCHIP_DECLARE().
I will drop interrupt-controller/cells and convert the driver to use
IRQCHIP_PLATFORM_DRIVER_BEGIN/END().
>> +
>> + msi-controller: true
>
> Drop and use 'unevaluatedProperties'.
OK.
>
>> +
>> + "#msi-cells":
>> + enum: [0]
>
> const: 0
OK.
>
>> +
>> + msi-ranges: true
>
> Drop.
OK.
>
>> +
>> +additionalProperties: false
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupt-controller
>> + - "#interrupt-cells"
>> + - msi-controller
>> + - msi-ranges
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> + axi {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + msi-controller@...0130000 {
>> + compatible = "brcm,bcm2712-mip";
>> + reg = <0x10 0x00130000 0x00 0xc0>,
>> + <0xff 0xfffff000 0x00 0x1000>;
>> + msi-controller;
>> + #msi-cells = <0>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + msi-ranges = <&gicv2 GIC_SPI 128 IRQ_TYPE_EDGE_RISING 64>;
>> + };
>> + };
>> --
>> 2.35.3
>>
Powered by blists - more mailing lists