[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <mb61pmsk7natw.fsf@kernel.org>
Date: Mon, 16 Sep 2024 10:37:31 +0000
From: Puranjay Mohan <puranjay@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>, Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>, Catalin Marinas
<catalin.marinas@....com>, Will Deacon <will@...nel.org>, Mark Rutland
<mark.rutland@....com>, Mark Brown <broonie@...nel.org>, Kalesh Singh
<kaleshsingh@...gle.com>, chenqiwu <qiwuchen55@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: arm64: stacktrace: WARN_ON(state->common.pc == orig_pc) in
kunwind_recover_return_address()
Oleg Nesterov <oleg@...hat.com> writes:
> I don't know the details but people report that
> kunwind_recover_return_address() hits this warning.
>
> I know absolutely nothing about arm64 or kernel/trace/fgraph.c, but at
> first glance this code looks broken:
>
> kunwind_recover_return_address:
>
> ...
>
> orig_pc = ftrace_graph_ret_addr(state->task, NULL,
> state->common.pc,
> (void *)state->common.fp);
> if (WARN_ON_ONCE(state->common.pc == orig_pc))
>
> ftrace_graph_ret_addr:
>
> ...
>
> if (!idx)
> return ret;
>
>
> given that kunwind_recover_return_address() passes idx == NULL to
> ftrace_graph_ret_addr(), it should always return ret == state->common.pc ?
>
>
> Perhaps this connects to 29c1c24a27 ("function_graph: Fix up ftrace_graph_ret_addr()")
> and I have no idea if something like the patch below makes any sense.
>
Your finding is accurate.
It has been fixed in upstream by c060f93253ca ("arm64: stacktrace: fix
the usage of ftrace_graph_ret_addr()")
See: https://elixir.bootlin.com/linux/v6.11/source/arch/arm64/kernel/stacktrace.c#L111
Thanks,
Puranjay
Download attachment "signature.asc" of type "application/pgp-signature" (256 bytes)
Powered by blists - more mailing lists