linux-kernel - Re: [PATCH v2 6.10] LoongArch: KVM: Remove undefined a6 argument comment for kvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024091647-absolve-wharf-f271@gregkh>
Date: Mon, 16 Sep 2024 13:39:04 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: stable@...r.kernel.org, sashal@...nel.org, maobibo@...ngson.cn,
	guanwentao@...ontech.com, zhangdandan@...ontech.com,
	chenhuacai@...ngson.cn, zhaotianrui@...ngson.cn, kernel@...0n.name,
	kvm@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6.10] LoongArch: KVM: Remove undefined a6 argument
 comment for kvm_hypercall()

On Mon, Sep 16, 2024 at 05:28:57PM +0800, WangYuli wrote:
> From: Dandan Zhang <zhangdandan@...ontech.com>
> 
> [ Upstream commit 494b0792d962e8efac72b3a5b6d9bcd4e6fa8cf0 ]
> 
> The kvm_hypercall() set for LoongArch is limited to a1-a5. So the
> mention of a6 in the comment is undefined that needs to be rectified.
> 
> Reviewed-by: Bibo Mao <maobibo@...ngson.cn>
> Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
> Signed-off-by: Dandan Zhang <zhangdandan@...ontech.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> --
> Changlog:
>  *v1 -> v2: Correct the commit-msg format.
> ---
>  arch/loongarch/include/asm/kvm_para.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/loongarch/include/asm/kvm_para.h b/arch/loongarch/include/asm/kvm_para.h
> index 4ba2312e5f8c..6d5e9b6c5714 100644
> --- a/arch/loongarch/include/asm/kvm_para.h
> +++ b/arch/loongarch/include/asm/kvm_para.h
> @@ -28,9 +28,9 @@
>   * Hypercall interface for KVM hypervisor
>   *
>   * a0: function identifier
> - * a1-a6: args
> + * a1-a5: args
>   * Return value will be placed in a0.
> - * Up to 6 arguments are passed in a1, a2, a3, a4, a5, a6.
> + * Up to 5 arguments are passed in a1, a2, a3, a4, a5.
>   */
>  static __always_inline long kvm_hypercall0(u64 fid)
>  {
> -- 
> 2.43.0
> 
> 

Again, why is this needed?

thanks,

greg k-h