linux-kernel - Re: [PATCH v1 04/12] i2c: isch: Switch to memory mapped IO accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <uikfb52qduifmhnlkc43tgvmw2ok67eclqpokyrkp7sftetz3v@bs64p6aga6s3>
Date: Mon, 16 Sep 2024 13:58:06 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: kernel test robot <lkp@...el.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev, Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 04/12] i2c: isch: Switch to memory mapped IO accessors

On Mon, Sep 16, 2024 at 01:30:48PM GMT, Andy Shevchenko wrote:
> On Mon, Sep 16, 2024 at 12:10:32PM +0200, Andi Shyti wrote:
> > On Mon, Sep 16, 2024 at 12:07:28PM GMT, Andy Shevchenko wrote:
> > > On Sat, Sep 14, 2024 at 02:56:19PM +0800, kernel test robot wrote:
> 
> ...
> 
> > > >    drivers/i2c/busses/i2c-isch.c: In function 'smbus_sch_probe':
> > > > >> drivers/i2c/busses/i2c-isch.c:296:42: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=]
> > > >      296 |                 "SMBus SCH adapter at %04x", res->start);
> > > >          |                                       ~~~^   ~~~~~~~~~~
> > > >          |                                          |      |
> > > >          |                                          |      resource_size_t {aka long long unsigned int}
> > > >          |                                          unsigned int
> > > >          |                                       %04llx
> > > 
> > > Yeah, this should be something like %pa, but the problem with that that it
> > > always uses the same, fixed-width format with a prefix. We don't want this. But
> > > to make sure we have proper specifier we need to introduce a temporary variable
> > > and assign the resource start address to it and then use that variable in here.
> > > I'll update this in v2 and send it after we have v6.12-rc1 is out.
> > 
> > Feel free to send it, I will apply it in i2c/i2c-host-for-6.12,
> > that's where I'm collecting the next patches.
> 
> But I believe it's a material for v6.13, no?

yes, I gave it the wrong name :-)
I renamed it now to i2c/i2c-host-for-6.13(*).

But it doesn't matter. It will become the next i2c/i2c-host after
Linus has taken the actual for-6.12 patches into mainline.

> From the whole series the first patch is only a fix, the rest is pure
> refactoring and cleanup.

Yes, you can omit the first patch. It has already been sent in
the fixes pull request.

Andi

(*) https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git/log/?h=i2c/i2c-host-for-6.13