[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240916150809.21889537@donnerap.manchester.arm.com>
Date: Mon, 16 Sep 2024 15:08:09 +0100
From: Andre Przywara <andre.przywara@....com>
To: Kryštof Černý <cleverline1mc@...il.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Jernej
Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add
disable-wp to mmc0
On Sat, 14 Sep 2024 12:07:00 +0200
Kryštof Černý <cleverline1mc@...il.com> wrote:
> The board does not have wp pin/switch for micro SD card (mmc0).
That is true, but for *every* microSD card. So I wonder if we should add
this property to all of the boards? I believe none of the arm64 boards have
full size SD card slots?
Cheers,
Andre
> Signed-off-by: Kryštof Černý <cleverline1mc@...il.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> index 526443bb736c..18fa541795a6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> @@ -136,6 +136,7 @@ &mmc0 {
> vmmc-supply = <®_vcc3v3>;
> bus-width = <4>;
> cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
> + disable-wp;
> status = "okay";
> };
>
>
> ---
> base-commit: 57f962b956f1d116cd64d5c406776c4975de549d
> change-id: 20240914-b4-nanopineoplus2-fix-mmc0-wp-9d77fb9e6513
>
> Best regards,
Powered by blists - more mailing lists