linux-kernel - Re: [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <510bd1a2-bccb-4f80-980f-1a6eed5b683e@suse.de>
Date: Mon, 16 Sep 2024 16:26:34 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Javier Martinez Canillas <javierm@...hat.com>,
 linux-kernel@...r.kernel.org
Cc: Brian Norris <briannorris@...omium.org>, dri-devel@...ts.freedesktop.org,
 Borislav Petkov <bp@...en8.de>, Julius Werner <jwerner@...omium.org>,
 chrome-platform@...ts.linux.dev, intel-gfx@...ts.freedesktop.org,
 Hugues Bruant <hugues.bruant@...il.com>,
 Alex Deucher <alexander.deucher@....com>,
 Dan Carpenter <dan.carpenter@...aro.org>, Helge Deller <deller@....de>,
 Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v4 1/2] firmware: sysfb: Add a sysfb_handles_screen_info()
 helper function



Am 16.09.24 um 13:00 schrieb Javier Martinez Canillas:
> That can be used by drivers to check if the Generic System Framebuffers
> (sysfb) support can handle the data contained in the global screen_info.
>
> Drivers might need this information to know if have to setup the system
> framebuffer, or if they have to delegate this action to sysfb instead.
>
> Suggested-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>
> Changes in v4:
> - New patch to add sysfb_handles_screen_info() helper (Thomas Zimmermann).
>
>   drivers/firmware/sysfb.c | 19 +++++++++++++++++++
>   include/linux/sysfb.h    |  7 +++++++
>   2 files changed, 26 insertions(+)
>
> diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c
> index 02a07d3d0d40..770e74be14f3 100644
> --- a/drivers/firmware/sysfb.c
> +++ b/drivers/firmware/sysfb.c
> @@ -77,6 +77,25 @@ void sysfb_disable(struct device *dev)
>   }
>   EXPORT_SYMBOL_GPL(sysfb_disable);
>   
> +/**
> + * sysfb_handles_screen_info() - reports if sysfb handles the global screen_info
> + *
> + * Callers can use sysfb_handles_screen_info() to determine whether the Generic
> + * System Framebuffers (sysfb) can handle the global screen_info data structure
> + * or not. Drivers might need this information to know if they have to setup the
> + * system framebuffer, or if they have to delegate this action to sysfb instead.
> + *
> + * Returns:
> + * True if sysfb handles the global screen_info data structure.
> + */
> +bool sysfb_handles_screen_info(void)
> +{
> +	const struct screen_info *si = &screen_info;
> +
> +	return !!screen_info_video_type(si);
> +}
> +EXPORT_SYMBOL_GPL(sysfb_handles_screen_info);
> +
>   #if defined(CONFIG_PCI)
>   static bool sysfb_pci_dev_is_enabled(struct pci_dev *pdev)
>   {
> diff --git a/include/linux/sysfb.h b/include/linux/sysfb.h
> index bef5f06a91de..07cbab516942 100644
> --- a/include/linux/sysfb.h
> +++ b/include/linux/sysfb.h
> @@ -60,12 +60,19 @@ struct efifb_dmi_info {
>   
>   void sysfb_disable(struct device *dev);
>   
> +bool sysfb_handles_screen_info(void);
> +
>   #else /* CONFIG_SYSFB */
>   
>   static inline void sysfb_disable(struct device *dev)
>   {
>   }
>   
> +static inline bool sysfb_handles_screen_info(void)
> +{
> +	return false;
> +}
> +
>   #endif /* CONFIG_SYSFB */
>   
>   #ifdef CONFIG_EFI

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)