linux-kernel - Re: [PATCH v2 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240916143130835e72b4@mail.local>
Date: Mon, 16 Sep 2024 16:31:30 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Andrei Simion <andrei.simion@...rochip.com>
Cc: claudiu.beznea@...on.dev, lgirdwood@...il.com, broonie@...nel.org,
	perex@...ex.cz, tiwai@...e.com, nicolas.ferre@...rochip.com,
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Subject: Re: [PATCH v2 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support
 due to single channel limitation

On 16/09/2024 16:19:10+0300, Andrei Simion wrote:
> From: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> 
> Drop S24_LE format because it is not supported if more than 2 channels
> (of TDM slots) are used. This limitation makes it impractical for use cases
> requiring more than 2 TDM slots, leading to potential issues in
> multi-channel configurations.
> 
> [andrei.simion@...rochip.com: Reword the commit title and the commit
> message. Add code comment to explain the removed code.]
> 
Reviewed-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
> ---
> v1 -> v2:
> - add code comment to explain why S24_LE is dropped.
> ---
>  sound/soc/atmel/atmel_ssc_dai.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 7047f17fe7a8..89098f41679c 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component)
>  	return 0;
>  }
>  
> +/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */
>  #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8     | SNDRV_PCM_FMTBIT_S16_LE |\
> -			  SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
> +			   SNDRV_PCM_FMTBIT_S32_LE)
>  
>  static const struct snd_soc_dai_ops atmel_ssc_dai_ops = {
>  	.startup	= atmel_ssc_startup,
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com