linux-kernel - Re: [PATCH] zram: free secondary algorithms names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240916074423.36ec570115c556ff0ab78425@linux-foundation.org>
Date: Mon, 16 Sep 2024 07:44:23 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] zram: free secondary algorithms names

On Wed, 11 Sep 2024 11:54:56 +0900 Sergey Senozhatsky <senozhatsky@...omium.org> wrote:

> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -2115,6 +2115,13 @@ static void zram_destroy_comps(struct zram *zram)
>  		zram->num_active_comps--;
>  	}
>  
> +	for (prio = ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {
> +		if (!zram->comp_algs[prio])
> +			continue;

We'll probably get emails telling us that this test-for-null is unneeded...

> +		kfree(zram->comp_algs[prio]);
> +		zram->comp_algs[prio] = NULL;
> +	}
> +
>  	zram_comp_params_reset(zram);
>  }