linux-kernel - Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cfe3f3a-28a3-4030-b6ba-3892a2a7bc79@linaro.org>
Date: Mon, 16 Sep 2024 18:10:55 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Emanuele Ghidoli <ghidoliemanuele@...il.com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org
Cc: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
 Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879_ts label to
 touchscreen controller

On 10/09/2024 17:22, Emanuele Ghidoli wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> 
> The device tree defines the touchscreen controller, but it cannot be
> enabled because it lacks a reference label.

It can be. Just enable it...

> This commit adds a label to allow it to be referenced and enabled.
> 

You changed here nothing. For me this patch is churn and pointless.

You add the label when you need to use it.

Best regards,
Krzysztof