linux-kernel - Re: [PATCH v2 1/3] dt-bindings: soc: spacemit: Add spacemit,k1-syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <enzkaomrdmftp5adcexj55zklgzo7hx25becllpnib2rqmhn2d@hu3yylm6nnej>
Date: Tue, 17 Sep 2024 08:15:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Haylen Chu <heylenay@...look.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-riscv@...ts.infradead.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Inochi Amaoto <inochiama@...look.com>, 
	Chen Wang <unicornxdotw@...mail.com>, Jisheng Zhang <jszhang@...nel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: spacemit: Add spacemit,k1-syscon

On Mon, Sep 16, 2024 at 10:23:08PM +0000, Haylen Chu wrote:
> Add documentation to describe Spacemit K1 system controller registers.
> 
> Signed-off-by: Haylen Chu <heylenay@...look.com>
> ---
>  .../soc/spacemit/spacemit,k1-syscon.yaml      | 47 +++++++++++++++++++
>  1 file changed, 47 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> 
> diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> new file mode 100644
> index 000000000000..4e3a72b48aff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/spacemit/spacemit,k1-syscon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spacemit K1 SoC System Controller
> +
> +maintainers:
> +  - Haylen Chu <heylenay@...look.com>
> +
> +description:
> +  The Spacemit K1 SoC system controller provides access to shared register files
> +  for related SoC modules, such as clock controller and reset controller.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - spacemit,k1-apbc-syscon
> +          - spacemit,k1-apbs-syscon
> +          - spacemit,k1-apmu-syscon
> +          - spacemit,k1-mpmu-syscon
> +      - const: syscon
> +      - const: simple-mfd

Drop, not used. Or make the binding complete.

> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":

Drop

> +    const: 1
> +
> +  "#size-cells":

Drop, not used.

> +    const: 1
> +
> +additionalProperties: false

This goes after required:

> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    syscon_mpmu: system-controller@...50000 {
> +        compatible = "spacemit,mpmu-syscon", "syscon", "simple-mfd";

This is example from something entirely different.

> +        reg = <0xd4050000 0x209c>;
> +    };
> -- 
> 2.46.0
>