linux-kernel - Re: [PATCH v3] fs/exfat: resolve memory leak from exfat_create_upcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-__5jnU3znV5qR1SVNaogqAbR-eQW2V_+LsbeVWRb50A@mail.gmail.com>
Date: Tue, 17 Sep 2024 15:40:38 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Daniel Yang <danielyangkang@...il.com>
Cc: viro@...iv.linux.org.uk, Sungjong Seo <sj1557.seo@...sung.com>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzbot+e1c69cadec0f1a078e3d@...kaller.appspotmail.com
Subject: Re: [PATCH v3] fs/exfat: resolve memory leak from exfat_create_upcase_table()

On Tue, Sep 17, 2024 at 8:05 AM Daniel Yang <danielyangkang@...il.com> wrote:
>
>     If exfat_load_upcase_table reaches end and returns -EINVAL,
>     allocated memory doesn't get freed and while
>     exfat_load_default_upcase_table allocates more memory, leading to a
>     memory leak.
>
>     Here's link to syzkaller crash report illustrating this issue:
>     https://syzkaller.appspot.com/text?tag=CrashReport&x=1406c201980000
>
> Signed-off-by: Daniel Yang <danielyangkang@...il.com>
> Reported-by: syzbot+e1c69cadec0f1a078e3d@...kaller.appspotmail.com
> ---
> V2 -> V3: free(NULL) is no-op, removed if() check
> V1 -> V2: Moved the mem free to create_upcase_table
Applied it to #dev now.
Thanks for your work!