linux-kernel - Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99a6eec3-ed24-47b2-af07-b4764c6de6a9@linaro.org>
Date: Tue, 17 Sep 2024 10:21:16 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Emanuele Ghidoli <ghidoliemanuele@...il.com>,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
 Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v1] arm64: dts: colibri-imx8x: Add ad7879_ts label to
 touchscreen controller

On 17/09/2024 09:45, Francesco Dolcini wrote:
> Hello Krzysztof,
> it seems that this patch requires more explanation, maybe something
> that should be part of the commit message, let's see ...
> 
> On Mon, Sep 16, 2024 at 06:10:55PM +0200, Krzysztof Kozlowski wrote:
>> On 10/09/2024 17:22, Emanuele Ghidoli wrote:
>>> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
>>>
>>> The device tree defines the touchscreen controller, but it cannot be
>>> enabled because it lacks a reference label.
>>
>> It can be. Just enable it...
> 
> colibri-imx8x is a SoM, it's not a complete self-contained device. The
> display touch controller is part of the SoM, however it is kept disabled
> since you need an actual touchscreen to make any use of it.
> 
> This label would be used where an actual touchscreen is defined, this can
> happen with a DT overlay, for example.

DT overlay should be in the tree.

> 
>>> This commit adds a label to allow it to be referenced and enabled.
>>
>> You changed here nothing. For me this patch is churn and pointless.
>> You add the label when you need to use it.
> 
> DT files from the Linux kernel GIT are used also outside the Linux kernel
> sources, see for example U-Boot OF_UPSTREAM [1], to me it's fair to add
> a label for an out-of-tree user, am I wrong?


For U-Boot or any other upstream project: yes. It's enough to point to
lore patch or lore link. For downstream projects: I don't care, just
churn. Downstream should upstream their stuff to be considered.

Best regards,
Krzysztof