linux-kernel - Re: [PATCH] virtio_console: fix misc probe bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22b91bc1410bf2a9b54b69a56075d368bf3e06d1.camel@kernel.org>
Date: Tue, 17 Sep 2024 10:39:55 +0200
From: Amit Shah <amit@...nel.org>
To: "Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	 <gregkh@...uxfoundation.org>, Rusty Russell <rusty@...tcorp.com.au>, 
	virtualization@...ts.linux.dev
Subject: Re: [PATCH] virtio_console: fix misc probe bugs

On Mon, 2024-09-16 at 14:32 -0400, Michael S. Tsirkin wrote:
> This fixes the following issue discovered by code review:
> 
> after vqs have been created, a buggy device can send an interrupt.
> 
> A control vq callback will then try to schedule control_work which
> has
> not been initialized yet. Similarly for config interrupt.  Further,
> in
> and out vq callbacks invoke find_port_by_vq which attempts to take
> ports_lock which also has not been initialized.
> 
> To fix, init all locks and work before creating vqs.
> 
> Fixes: 17634ba25544 ("virtio: console: Add a new MULTIPORT feature,
> support for generic ports")
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>

Reviewed-by: Amit Shah <amit@...nel.org>