linux-kernel - Re: [PATCH] list: Remove duplicated and unused macro list_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7478478c-14e0-4760-b018-6bcf282db1b9@icloud.com>
Date: Tue, 17 Sep 2024 18:36:43 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>, stable@...r.kernel.org
Subject: Re: [PATCH] list: Remove duplicated and unused macro
 list_for_each_reverse

On 2024/9/17 15:49, Greg Kroah-Hartman wrote:
> On Tue, Sep 17, 2024 at 03:28:18PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> Remove macro list_for_each_reverse due to below reasons:
>>
>> - it is same as list_for_each_prev.
>> - it is not used by current kernel tree.
>>
>> Fixes: 8bf0cdfac7f8 ("<linux/list.h>: Introduce the list_for_each_reverse() method")
> 
> Why is this a "Fix:"?
> 

thank you for code review.
Will remove fix tag for next revision and manually loop author of fixes
tag commit.

>> Cc: stable@...r.kernel.org
> 

will remove Cc tag for next revision as well. (^^)

> Why is this for stable?  What does this fix?  Just removing code that no
> one uses doesn't need to be backported, it's just dead, delete it.
> 
> thanks,
> 
> greg k-h