linux-kernel - Re: [PATCH v12 3/5] firmware: ti_sci: Add system suspend and resume call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o74mlek0.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date: Tue, 17 Sep 2024 16:42:15 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Markus Schneider-Pargmann <msp@...libre.com>, Nishanth Menon <nm@...com>,
        Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@....cz>,
        "Len
 Brown" <len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Vibhore Vardhan <vibhore@...com>, Kevin Hilman <khilman@...libre.com>,
        Dhruva Gole <d-gole@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        Dave Gerlach
	<d-gerlach@...com>, Georgi Vlaev <g-vlaev@...com>,
        "Markus
 Schneider-Pargmann" <msp@...libre.com>
Subject: Re: [PATCH v12 3/5] firmware: ti_sci: Add system suspend and resume
 call

Markus Schneider-Pargmann <msp@...libre.com> writes:
...
>  
> +static int ti_sci_prepare_system_suspend(struct ti_sci_info *info)
> +{
> +	/*
> +	 * Map and validate the target Linux suspend state to TISCI LPM.
> +	 * Default is to let Device Manager select the low power mode.
> +	 */
> +	switch (pm_suspend_target_state) {
> +	case PM_SUSPEND_MEM:
> +		if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) {
> +			/*
> +			 * For the DM_MANAGED mode the context is reserved for
> +			 * internal use and can be 0
> +			 */
> +			return ti_sci_cmd_prepare_sleep(&info->handle,
> +							TISCI_MSG_VALUE_SLEEP_MODE_DM_MANAGED,
> +							0, 0, 0);
> +		} else {
> +			/* DM Managed is not supported by the firmware. */
> +			dev_err(info->dev, "Suspend to memory is not supported by the firmware\n");
> +			return -EOPNOTSUPP;
> +		}
> +		break;
> +	default:
> +		/*
> +		 * Do not fail if we don't have action to take for a
> +		 * specific suspend mode.
> +		 */
> +		return 0;
> +	}
> +
> +	return 0;

Looks like this statement is unreachable, may be generating a warning as well.

> +}
> +
...